From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link |
Date: | 2007-11-13 18:50:55 |
Message-ID: | 200711131850.lADIotV25841@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > > > Am Samstag, 10. November 2007 schrieb Bruce Momjian:
> > > >> Use strip -x on OS/X-darwin because non-"-x" causes link problems:
> > >
> > > > How will this work, considering that $template isn't set anywhere?
> > >
> > > It won't, of course. Perhaps something like
> > >
> > > if test `uname -s` = Darwin
> > >
> > > instead.
> >
> > I am afraid some unames don't have -s, so I did uname -a and tested for
> > it starting with Darwin. Patch attached and applied.
>
> Hmm, this doesn't seem to work for me:
>
> $ if test expr "`uname -a`" : 'Darwin' -ne 0
> > then stripprog="${STRIPPROG-strip -x}"
> > else stripprog="${STRIPPROG-strip}"
> > fi
> -bash: test: too many arguments
Sorry, corrected patch attached, tested, and applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachment | Content-Type | Size |
---|---|---|
/rtmp/diff | text/x-diff | 992 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2007-11-13 18:57:49 | Re: [HACKERS] pgsql: Use strip -x on OS/X-darwinbecause non-"-x" causes link |
Previous Message | Bruce Momjian | 2007-11-13 18:50:54 | pgsql: Again properly fix Darwin strip. |
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2007-11-13 18:57:49 | Re: [HACKERS] pgsql: Use strip -x on OS/X-darwinbecause non-"-x" causes link |
Previous Message | Alvaro Herrera | 2007-11-13 18:37:56 | Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link |