Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link
Date: 2007-11-13 18:15:53
Message-ID: 200711131815.lADIFrD29372@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Am Samstag, 10. November 2007 schrieb Bruce Momjian:
> >> Use strip -x on OS/X-darwin because non-"-x" causes link problems:
>
> > How will this work, considering that $template isn't set anywhere?
>
> It won't, of course. Perhaps something like
>
> if test `uname -s` = Darwin
>
> instead.

I am afraid some unames don't have -s, so I did uname -a and tested for
it starting with Darwin. Patch attached and applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 976 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2007-11-13 18:37:56 Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link
Previous Message Bruce Momjian 2007-11-13 18:15:01 pgsql: Modify OS/X Darin test to actually work, (no $template)

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-11-13 18:37:56 Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link
Previous Message Tom Lane 2007-11-13 17:15:56 Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link