From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | dmitry(at)karasik(dot)eu(dot)org, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: implement prepared queries in plperl |
Date: | 2006-03-01 22:42:40 |
Message-ID: | 200603012242.k21MgeU26583@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Is this patch going to be applied?
---------------------------------------------------------------------------
Andrew Dunstan wrote:
>
>
> Dmitry Karasik wrote:
>
> [patch snipped]
>
> I have cleaned this patch somewhat by removing some bitrot that occurred
> since it was submitted, and adjusting formatting to something more
> closely resembling postgresql style (please remember to follow our style
> in future).
>
> The attached works on HEAD and passes the supplied regression tests.
>
> But why do we have to call spi_freeplan? pltcl, which has prepared
> queries, doesn't require this AFAICS. If memory leaks are an issue,
> maybe we should bless the object into a class with a DESTROY method that
> calls spi_freeplan automatically (not sure to do that in XS but I assume
> it's possible).
>
> cheers
>
> andrew
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org
--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-03-01 22:45:47 | Re: [SQL] Interval subtracting |
Previous Message | Mark Kirkwood | 2006-03-01 22:39:18 | Re: pg_config, pg_service.conf, postgresql.conf .... |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-03-01 22:45:47 | Re: [SQL] Interval subtracting |
Previous Message | Mark Dilger | 2006-03-01 22:30:11 | Re: [SQL] Interval subtracting |