From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | dmitry(at)karasik(dot)eu(dot)org, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: implement prepared queries in plperl |
Date: | 2006-02-19 16:38:12 |
Message-ID: | 43F89EF4.6020106@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Dmitry Karasik wrote:
[patch snipped]
I have cleaned this patch somewhat by removing some bitrot that occurred
since it was submitted, and adjusting formatting to something more
closely resembling postgresql style (please remember to follow our style
in future).
The attached works on HEAD and passes the supplied regression tests.
But why do we have to call spi_freeplan? pltcl, which has prepared
queries, doesn't require this AFAICS. If memory leaks are an issue,
maybe we should bless the object into a class with a DESTROY method that
calls spi_freeplan automatically (not sure to do that in XS but I assume
it's possible).
cheers
andrew
Attachment | Content-Type | Size |
---|---|---|
pq-updated.patch | text/x-patch | 25.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-02-19 17:10:16 | Re: Prepared Xacts and Vacuum question |
Previous Message | Douglas McNaught | 2006-02-19 16:15:46 | Re: pg_service.conf |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-02-19 17:41:21 | Re: pg_service.conf |
Previous Message | Douglas McNaught | 2006-02-19 16:15:46 | Re: pg_service.conf |