Comments on patch for date_trunc( 'week', ... );

--Multipart_Sun__29_Feb_2004_17_11_05_-0700_=.w_KmuR(eRfU8lY
Content-Type: multipart/mixed;
boundary="Multipart_Sun__29_Feb_2004_17_11_05_-0700_=.efcc)pQwOzEslc"

--Multipart_Sun__29_Feb_2004_17_11_05_-0700_=.efcc)pQwOzEslc
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Per a brief conversation with Tom, I've created a patch for adding support for
'week' within the date_trunc function.

Within the patch I added a couple of test cases and associated target output,
and changed the documentation to add 'week' appropriately.

Comments? Should I of bypassed this list and subscribed/posted to the patch
list?

Cheers,
Rob

--
17:07:39 up 15 days, 46 min, 4 users, load average: 2.18, 2.23, 2.27
Linux 2.4.21-0.13_test #60 SMP Sun Dec 7 17:00:02 MST 2003

--Multipart_Sun__29_Feb_2004_17_11_05_-0700_=.efcc)pQwOzEslc
Content-Type: application/octet-stream;
name="date_trunc.patch"
Content-Disposition: attachment;
filename="date_trunc.patch"
Content-Transfer-Encoding: base64

SW5kZXg6IGRvYy9zcmMvc2dtbC9mdW5jLnNnbWwKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQpSQ1MgZmlsZTogL3Byb2plY3RzL2N2c3Jvb3QvcGdzcWwtc2Vy
dmVyL2RvYy9zcmMvc2dtbC9mdW5jLnNnbWwsdgpyZXRyaWV2aW5nIHJldmlz
aW9uIDEuMTg5CmRpZmYgLXUgLXIxLjE4OSBmdW5jLnNnbWwKLS0tIGRvYy9z
cmMvc2dtbC9mdW5jLnNnbWwJMjkgRmViIDIwMDQgMTU6NDU6NTMgLTAwMDAJ
MS4xODkKKysrIGRvYy9zcmMvc2dtbC9mdW5jLnNnbWwJMjkgRmViIDIwMDQg
MjM6NDQ6MzIgLTAwMDAKQEAgLTUzMDYsNiArNTMwNiw3IEBACiAgICAgIDxt
ZW1iZXI+PGxpdGVyYWw+bWludXRlPC9saXRlcmFsPjwvbWVtYmVyPgogICAg
ICA8bWVtYmVyPjxsaXRlcmFsPmhvdXI8L2xpdGVyYWw+PC9tZW1iZXI+CiAg
ICAgIDxtZW1iZXI+PGxpdGVyYWw+ZGF5PC9saXRlcmFsPjwvbWVtYmVyPgor
ICAgICA8bWVtYmVyPjxsaXRlcmFsPndlZWs8L2xpdGVyYWw+PC9tZW1iZXI+
CiAgICAgIDxtZW1iZXI+PGxpdGVyYWw+bW9udGg8L2xpdGVyYWw+PC9tZW1i
ZXI+CiAgICAgIDxtZW1iZXI+PGxpdGVyYWw+eWVhcjwvbGl0ZXJhbD48L21l
bWJlcj4KICAgICAgPG1lbWJlcj48bGl0ZXJhbD5kZWNhZGU8L2xpdGVyYWw+
PC9tZW1iZXI+CkluZGV4OiBzcmMvYmFja2VuZC91dGlscy9hZHQvdGltZXN0
YW1wLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3Byb2pl
Y3RzL2N2c3Jvb3QvcGdzcWwtc2VydmVyL3NyYy9iYWNrZW5kL3V0aWxzL2Fk
dC90aW1lc3RhbXAuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS45OQpkaWZm
IC11IC1yMS45OSB0aW1lc3RhbXAuYwotLS0gc3JjL2JhY2tlbmQvdXRpbHMv
YWR0L3RpbWVzdGFtcC5jCTE0IEZlYiAyMDA0IDIwOjE2OjE3IC0wMDAwCTEu
OTkKKysrIHNyYy9iYWNrZW5kL3V0aWxzL2FkdC90aW1lc3RhbXAuYwkyOSBG
ZWIgMjAwNCAyMzo0NDozNCAtMDAwMApAQCAtMjU2NCw2ICsyNTY0LDEzIEBA
CiAKIAkJc3dpdGNoICh2YWwpCiAJCXsKKwkJCWNhc2UgRFRLX1dFRUs6CisJ
CQkJaXNvd2VlazJkYXRlKCBkYXRlMmlzb3dlZWsoIHRtLT50bV95ZWFyLCB0
bS0+dG1fbW9uLCB0bS0+dG1fbWRheSApLCAmKHRtLT50bV95ZWFyKSwgJih0
bS0+dG1fbW9uKSwgJih0bS0+dG1fbWRheSkgKTsKKwkJCQl0bS0+dG1faG91
ciA9IDA7CisJCQkJdG0tPnRtX21pbiA9IDA7CisJCQkJdG0tPnRtX3NlYyA9
IDA7CisJCQkJZnNlYyA9IDA7CisJCQkJYnJlYWs7CiAJCQljYXNlIERUS19N
SUxMRU5OSVVNOgogCQkJCXRtLT50bV95ZWFyID0gKHRtLT50bV95ZWFyIC8g
MTAwMCkgKiAxMDAwOwogCQkJY2FzZSBEVEtfQ0VOVFVSWToKQEAgLTI2NzIs
NiArMjY3OSwxMyBAQAogCiAJCXN3aXRjaCAodmFsKQogCQl7CisJCQljYXNl
IERUS19XRUVLOgorCQkJCWlzb3dlZWsyZGF0ZSggZGF0ZTJpc293ZWVrKCB0
bS0+dG1feWVhciwgdG0tPnRtX21vbiwgdG0tPnRtX21kYXkgKSwgJih0bS0+
dG1feWVhciksICYodG0tPnRtX21vbiksICYodG0tPnRtX21kYXkpICk7CisJ
CQkJdG0tPnRtX2hvdXIgPSAwOworCQkJCXRtLT50bV9taW4gPSAwOworCQkJ
CXRtLT50bV9zZWMgPSAwOworCQkJCWZzZWMgPSAwOworCQkJCWJyZWFrOwog
CQkJY2FzZSBEVEtfTUlMTEVOTklVTToKIAkJCQl0bS0+dG1feWVhciA9ICh0
bS0+dG1feWVhciAvIDEwMDApICogMTAwMDsKIAkJCWNhc2UgRFRLX0NFTlRV
Ulk6CkluZGV4OiBzcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3RpbWVzdGFt
cC5vdXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3Byb2pl
Y3RzL2N2c3Jvb3QvcGdzcWwtc2VydmVyL3NyYy90ZXN0L3JlZ3Jlc3MvZXhw
ZWN0ZWQvdGltZXN0YW1wLm91dCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4y
NQpkaWZmIC11IC1yMS4yNSB0aW1lc3RhbXAub3V0Ci0tLSBzcmMvdGVzdC9y
ZWdyZXNzL2V4cGVjdGVkL3RpbWVzdGFtcC5vdXQJMjUgU2VwIDIwMDMgMDY6
NTg6MDYgLTAwMDAJMS4yNQorKysgc3JjL3Rlc3QvcmVncmVzcy9leHBlY3Rl
ZC90aW1lc3RhbXAub3V0CTI5IEZlYiAyMDA0IDIzOjQ0OjM2IC0wMDAwCkBA
IC00OTksNiArNDk5LDEyIEBACiAgICAgfCBAIDE0NjAgZGF5cyAxNyBob3Vy
cyAzMiBtaW5zIDEgc2VjCiAoNTQgcm93cykKIAorU0VMRUNUICcnIEFTIGRh
dGVfdHJ1bmNfd2VlaywgZGF0ZV90cnVuYyggJ3dlZWsnLCB0aW1lc3RhbXAg
JzIwMDQtMDItMjkgMTU6NDQ6MTcuNzEzOTMnICkgQVMgd2Vla190cnVuYzsK
KyBkYXRlX3RydW5jX3dlZWsgfCAgICAgICAgd2Vla190cnVuYyAgICAgICAg
CistLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LQorICAgICAgICAgICAgICAgICB8IE1vbiBGZWIgMjMgMDA6MDA6MDAgMjAw
NAorKDEgcm93KQorCiAtLSBUZXN0IGNhc3Rpbmcgd2l0aGluIGEgQkVUV0VF
TiBxdWFsaWZpZXIKIFNFTEVDVCAnJyBBUyAiNTQiLCBkMSAtIHRpbWVzdGFt
cCB3aXRob3V0IHRpbWUgem9uZSAnMTk5Ny0wMS0wMicgQVMgZGlmZgogICBG
Uk9NIFRJTUVTVEFNUF9UQkwKSW5kZXg6IHNyYy90ZXN0L3JlZ3Jlc3MvZXhw
ZWN0ZWQvdGltZXN0YW1wdHoub3V0Cj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
UkNTIGZpbGU6IC9wcm9qZWN0cy9jdnNyb290L3Bnc3FsLXNlcnZlci9zcmMv
dGVzdC9yZWdyZXNzL2V4cGVjdGVkL3RpbWVzdGFtcHR6Lm91dCx2CnJldHJp
ZXZpbmcgcmV2aXNpb24gMS4xNApkaWZmIC11IC1yMS4xNCB0aW1lc3RhbXB0
ei5vdXQKLS0tIHNyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvdGltZXN0YW1w
dHoub3V0CTI1IERlYyAyMDAzIDAzOjM2OjI0IC0wMDAwCTEuMTQKKysrIHNy
Yy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvdGltZXN0YW1wdHoub3V0CTI5IEZl
YiAyMDA0IDIzOjQ0OjM2IC0wMDAwCkBAIC00OTQsNiArNDk0LDEyIEBACiAg
ICAgfCBAIDE0NjAgZGF5cyAxNyBob3VycyAzMiBtaW5zIDEgc2VjCiAoNTQg
cm93cykKIAorU0VMRUNUICcnIEFTIGRhdGVfdHJ1bmNfd2VlaywgZGF0ZV90
cnVuYyggJ3dlZWsnLCB0aW1lc3RhbXAgd2l0aCB0aW1lIHpvbmUgJzIwMDQt
MDItMjkgMTU6NDQ6MTcuNzEzOTMnICkgQVMgd2Vla190cnVuYzsKKyBkYXRl
X3RydW5jX3dlZWsgfCAgICAgICAgICB3ZWVrX3RydW5jICAgICAgICAgIAor
LS0tLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tCisgICAgICAgICAgICAgICAgIHwgTW9uIEZlYiAyMyAwMDowMDowMCAy
MDA0IFBTVAorKDEgcm93KQorCiAtLSBUZXN0IGNhc3Rpbmcgd2l0aGluIGEg
QkVUV0VFTiBxdWFsaWZpZXIKIFNFTEVDVCAnJyBBUyAiNTQiLCBkMSAtIHRp
bWVzdGFtcCB3aXRoIHRpbWUgem9uZSAnMTk5Ny0wMS0wMicgQVMgZGlmZgog
ICBGUk9NIFRJTUVTVEFNUFRaX1RCTApAQCAtMTMxNyw5ICsxMzIzLDkgQEAK
ICAgICAgICAgICAgfCAyMDAxIEEuRC4gMjAwMSBhLmQuIDIwMDEgYWQgMDU6
MzI6MDEgUC5NLiAwNTozMjowMSBwLm0uIDA1OjMyOjAxIHBtCiAoNjQgcm93
cykKIAotU0VMRUNUICcnIEFTIHRvX2NoYXJfMTAsIHRvX2NoYXIoZDEsICdZ
WVlZIFdXIElZWVkgSVlZIElZIEkgSVcnKQorU0VMRUNUICcnIEFTIHRvX2No
YXJfMTAsIHRvX2NoYXIoZDEsICdZWVlZIFdXIElZWVkgSVlZIElZIEkgSVcn
KSAKICAgIEZST00gVElNRVNUQU1QVFpfVEJMOwotIHRvX2NoYXJfMTAgfCAg
ICAgdG9fY2hhcgorIHRvX2NoYXJfMTAgfCAgICAgICAgIHRvX2NoYXIgICAg
ICAgICAgCiAtLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0KICAgICAgICAgICAgIHwgCiAgICAgICAgICAgICB8IApJbmRleDogc3Jj
L3Rlc3QvcmVncmVzcy9zcWwvdGltZXN0YW1wLnNxbAo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09ClJDUyBmaWxlOiAvcHJvamVjdHMvY3Zzcm9vdC9wZ3NxbC1z
ZXJ2ZXIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvdGltZXN0YW1wLnNxbCx2CnJl
dHJpZXZpbmcgcmV2aXNpb24gMS4xMgpkaWZmIC11IC1yMS4xMiB0aW1lc3Rh
bXAuc3FsCi0tLSBzcmMvdGVzdC9yZWdyZXNzL3NxbC90aW1lc3RhbXAuc3Fs
CTI5IEp1bCAyMDAzIDAwOjAzOjE5IC0wMDAwCTEuMTIKKysrIHNyYy90ZXN0
L3JlZ3Jlc3Mvc3FsL3RpbWVzdGFtcC5zcWwJMjkgRmViIDIwMDQgMjM6NDQ6
MzYgLTAwMDAKQEAgLTE1MSw2ICsxNTEsOCBAQAogU0VMRUNUICcnIEFTICI1
NCIsIGQxIC0gdGltZXN0YW1wIHdpdGhvdXQgdGltZSB6b25lICcxOTk3LTAx
LTAyJyBBUyBkaWZmCiAgICBGUk9NIFRJTUVTVEFNUF9UQkwgV0hFUkUgZDEg
QkVUV0VFTiAnMTkwMi0wMS0wMScgQU5EICcyMDM4LTAxLTAxJzsKIAorU0VM
RUNUICcnIEFTIGRhdGVfdHJ1bmNfd2VlaywgZGF0ZV90cnVuYyggJ3dlZWsn
LCB0aW1lc3RhbXAgJzIwMDQtMDItMjkgMTU6NDQ6MTcuNzEzOTMnICkgQVMg
d2Vla190cnVuYzsKKwogLS0gVGVzdCBjYXN0aW5nIHdpdGhpbiBhIEJFVFdF
RU4gcXVhbGlmaWVyCiBTRUxFQ1QgJycgQVMgIjU0IiwgZDEgLSB0aW1lc3Rh
bXAgd2l0aG91dCB0aW1lIHpvbmUgJzE5OTctMDEtMDInIEFTIGRpZmYKICAg
RlJPTSBUSU1FU1RBTVBfVEJMCkluZGV4OiBzcmMvdGVzdC9yZWdyZXNzL3Nx
bC90aW1lc3RhbXB0ei5zcWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg
ZmlsZTogL3Byb2plY3RzL2N2c3Jvb3QvcGdzcWwtc2VydmVyL3NyYy90ZXN0
L3JlZ3Jlc3Mvc3FsL3RpbWVzdGFtcHR6LnNxbCx2CnJldHJpZXZpbmcgcmV2
aXNpb24gMS41CmRpZmYgLXUgLXIxLjUgdGltZXN0YW1wdHouc3FsCi0tLSBz
cmMvdGVzdC9yZWdyZXNzL3NxbC90aW1lc3RhbXB0ei5zcWwJMjUgRGVjIDIw
MDMgMDM6MzY6MjQgLTAwMDAJMS41CisrKyBzcmMvdGVzdC9yZWdyZXNzL3Nx
bC90aW1lc3RhbXB0ei5zcWwJMjkgRmViIDIwMDQgMjM6NDQ6MzYgLTAwMDAK
QEAgLTE0NSw2ICsxNDUsOCBAQAogU0VMRUNUICcnIEFTICI1NCIsIGQxIC0g
dGltZXN0YW1wIHdpdGggdGltZSB6b25lICcxOTk3LTAxLTAyJyBBUyBkaWZm
CiAgICBGUk9NIFRJTUVTVEFNUFRaX1RCTCBXSEVSRSBkMSBCRVRXRUVOICcx
OTAyLTAxLTAxJyBBTkQgJzIwMzgtMDEtMDEnOwogCitTRUxFQ1QgJycgQVMg
ZGF0ZV90cnVuY193ZWVrLCBkYXRlX3RydW5jKCAnd2VlaycsIHRpbWVzdGFt
cCB3aXRoIHRpbWUgem9uZSAnMjAwNC0wMi0yOSAxNTo0NDoxNy43MTM5Mycg
KSBBUyB3ZWVrX3RydW5jOworCiAtLSBUZXN0IGNhc3Rpbmcgd2l0aGluIGEg
QkVUV0VFTiBxdWFsaWZpZXIKIFNFTEVDVCAnJyBBUyAiNTQiLCBkMSAtIHRp
bWVzdGFtcCB3aXRoIHRpbWUgem9uZSAnMTk5Ny0wMS0wMicgQVMgZGlmZgog
ICBGUk9NIFRJTUVTVEFNUFRaX1RCTAo=

--Multipart_Sun__29_Feb_2004_17_11_05_-0700_=.efcc)pQwOzEslc--

--Multipart_Sun__29_Feb_2004_17_11_05_-0700_=.w_KmuR(eRfU8lY
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iEYEARECAAYFAkBCf5kACgkQLQ/DKuwDYzne8wCaArjPnffqEpsXHsnsF96PGo+b
XHkAn1XYBCv0tNz1EXUupPzEiIfxSDcR
=H1zn
-----END PGP SIGNATURE-----

--Multipart_Sun__29_Feb_2004_17_11_05_-0700_=.w_KmuR(eRfU8lY--