Re: numeric/decimal docs bug?

From: Jan Wieck <janwieck(at)yahoo(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Jan Wieck <janwieck(at)yahoo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, Jan Wieck <JanWieck(at)yahoo(dot)com>
Subject: Re: numeric/decimal docs bug?
Date: 2002-04-12 22:48:51
Message-ID: 200204122248.g3CMmp807993@saturn.janwieck.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Jan Wieck wrote:
> > You forgot who wrote that code originally. I feel alot
> > better WITH the tests in place :-)
> >
> > And if it's merely to make sure the install worked, man who
> > is doing source installations these days and runs the
> > regression tests anyway? Most people throw in a RPM or the
> > like, only a few serious users install from sources, and only
> > a fistfull of them then runs regression.
> >
> > Aren't it mostly developers and distro-maintainers who use
> > that directory? I think your entire point isn't just weak,
> > IMNSVHO you don't really have a point.
>
> It is my understanding that RPM does run that test. My main issue is
> why does numeric have to be so much larger than the other tests? I have
> not heard that explained.

Well, I heard Thomas commenting that it's horribly slow
implemented (or so, don't recall his exact wording). But
he's right.

I think the same test done with float8 would run in less than
a tenth of that time. This is only an explanation "why it
takes so long"? It is no argument pro or con the test itself.

I think I made my point clear enough, that I consider calling
these functions just once is plain sloppy. But that's just
my opinion. What do others think?

Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-04-12 22:51:27 Re: pg_dump is broken in CVS tip
Previous Message Neil Conway 2002-04-12 22:44:17 Re: pg_dump is broken in CVS tip