From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Anders Bengtsson <ndrsbngtssn(at)yahoo(dot)se> |
Cc: | pgsql-patches(at)postgresql(dot)org, pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: Attempt to clean up ExecSql() in JDBC |
Date: | 2001-08-28 16:15:40 |
Message-ID: | 200108281615.f7SGFeq28851@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc pgsql-patches |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
>
> Hi,
>
> Attached is my attempt to clean up the horrors of the ExecSQL() method in
> the JDBC driver.
>
> I've done this by extracting it into a new method object called
> QueryExecutor (should go into org/postgresql/core/) and then taking it
> apart into different methods in that class.
>
> A short summary:
>
> * Extracted ExecSQL() from Connection into a method object called
> QueryExecutor.
>
> * Moved ReceiveFields() from Connection to QueryExecutor.
>
> * Extracted parts of the original ExecSQL() method body into smaller
> methods on QueryExecutor.
>
> * Bug fix: The instance variable "pid" in Connection was used in two
> places with different meaning. Both were probably in dead code, but it's
> fixed anyway.
>
> /Anders
>
>
> PS.: If anyone has any idea what the variable names "fqp" and "hfr" stand
> for, please tell me! :)
>
> _____________________________________________________________________
> A n d e r s B e n g t s s o n ndrsbngtssn(at)yahoo(dot)se
> Stockholm, Sweden
Content-Description:
[ Attachment, skipping... ]
Content-Description:
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-08-28 16:15:52 | Re: JDBC Statement.executeBatch patch |
Previous Message | Thomas O'Dowd | 2001-08-28 15:23:21 | Unterminated quoted string error. |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-08-28 16:15:52 | Re: JDBC Statement.executeBatch patch |
Previous Message | Bruce Momjian | 2001-08-28 16:15:07 | Re: PAM Authentication Patch, take one... |