From: | Anders Bengtsson <ndrsbngtssn(at)yahoo(dot)se> |
---|---|
To: | <pgsql-patches(at)postgresql(dot)org>, <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Attempt to clean up ExecSql() in JDBC |
Date: | 2001-08-26 18:57:42 |
Message-ID: | Pine.LNX.4.33.0108262036270.2048-300000@sensenet.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc pgsql-patches |
Hi,
Attached is my attempt to clean up the horrors of the ExecSQL() method in
the JDBC driver.
I've done this by extracting it into a new method object called
QueryExecutor (should go into org/postgresql/core/) and then taking it
apart into different methods in that class.
A short summary:
* Extracted ExecSQL() from Connection into a method object called
QueryExecutor.
* Moved ReceiveFields() from Connection to QueryExecutor.
* Extracted parts of the original ExecSQL() method body into smaller
methods on QueryExecutor.
* Bug fix: The instance variable "pid" in Connection was used in two
places with different meaning. Both were probably in dead code, but it's
fixed anyway.
/Anders
PS.: If anyone has any idea what the variable names "fqp" and "hfr" stand
for, please tell me! :)
_____________________________________________________________________
A n d e r s B e n g t s s o n ndrsbngtssn(at)yahoo(dot)se
Stockholm, Sweden
Attachment | Content-Type | Size |
---|---|---|
execsql.patch | text/plain | 10.8 KB |
QueryExecutor.java | text/plain | 5.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Rene Pijlman | 2001-08-26 19:14:49 | Status of JDBC test suite? |
Previous Message | Rene Pijlman | 2001-08-26 18:41:37 | JDBC Statement.executeBatch patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2001-08-26 20:05:44 | Re: Re: [PATCHES] Makefile.PL for Pg.so |
Previous Message | Trond Eivind =?iso-8859-1?q?Glomsr=F8d?= | 2001-08-26 18:46:54 | Re: Re: [PATCHES] Makefile.PL for Pg.so |