| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: trying again to get incremental backup |
| Date: | 2023-12-18 09:10:51 |
| Message-ID: | 1e3e7a09-5e3f-48b0-bd4a-5b9abda67ce2@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Another set of comments, about the patch that adds pg_combinebackup:
Make sure all the options are listed in a consistent order. We have
lately changed everything to be alphabetical. This includes:
- reference page pg_combinebackup.sgml
- long_options listing
- getopt_long() argument
- subsequent switch
- (--help output, but it looks ok as is)
Also, in pg_combinebackup.sgml, the option --sync-method is listed as if
it does not take an argument, but it does.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-12-18 09:31:03 | Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression |
| Previous Message | Nikita Malakhov | 2023-12-18 09:05:28 | Re: introduce dynamic shared memory registry |