| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: trying again to get incremental backup |
| Date: | 2023-12-18 18:58:17 |
| Message-ID: | CA+TgmoZ6UGZVnSy5iak6s6+AXu_DewXovDjhLs3-su6nmU_x_g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 18, 2023 at 4:10 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> Another set of comments, about the patch that adds pg_combinebackup:
>
> Make sure all the options are listed in a consistent order. We have
> lately changed everything to be alphabetical. This includes:
>
> - reference page pg_combinebackup.sgml
>
> - long_options listing
>
> - getopt_long() argument
>
> - subsequent switch
>
> - (--help output, but it looks ok as is)
>
> Also, in pg_combinebackup.sgml, the option --sync-method is listed as if
> it does not take an argument, but it does.
I've attempted to clean this stuff up in the attached version. This
version also includes a fix for the bug found by Jakub that caused
things to not work properly for segment files beyond the first for any
particular relation, which turns out to be a really stupid mistake in
my earlier commit 025584a168a4b3002e193.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v15-0001-Fix-brown-paper-bag-bug-in-025584a168a4b3002e193.patch | application/octet-stream | 986 bytes |
| v15-0005-Add-new-pg_walsummary-tool.patch | application/octet-stream | 18.3 KB |
| v15-0003-Add-a-new-WAL-summarizer-process.patch | application/octet-stream | 135.9 KB |
| v15-0002-Move-src-bin-pg_verifybackup-parse_manifest.c-in.patch | application/octet-stream | 5.1 KB |
| v15-0004-Add-support-for-incremental-backup.patch | application/octet-stream | 223.2 KB |
| v15-0006-Test-patch-Enable-summarize_wal-by-default.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-12-18 19:41:22 | Re: add non-option reordering to in-tree getopt_long |
| Previous Message | Robert Haas | 2023-12-18 18:39:33 | Re: trying again to get incremental backup |