| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, khuddleston(at)pivotal(dot)io, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14706: Dependencies not recorded properly for base types |
| Date: | 2017-06-15 16:38:24 |
| Message-ID: | 1c07c9a6-b56f-fe67-63a5-6913e78df1f6@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 06/15/2017 07:31 PM, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Hmm. Strictly speaking there's no need to update the dependency when
>> changing opaque into cstring. Because cstring is a pinned type,
>> recordDependency will do nothing for it.
>
>> But in any case, I think it'd be better and simpler to fix the
>> dependency in SetFunctionArgType() and SetFunctionReturnType() functions
>> themselves. They're the ones that change the type, they ought to be
>> responsible for fixing the dependency too. See attached.
>
> Yeah, Heikki's version looks good to me.
>
> Heikki, are you going to commit/backpatch this, or do you want me to?
I can do it, thanks.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | mark.manley | 2017-06-15 22:06:06 | BUG #14709: inconsistent answers with foreign data wrappers to mysql |
| Previous Message | Tom Lane | 2017-06-15 16:31:40 | Re: BUG #14706: Dependencies not recorded properly for base types |