| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, khuddleston(at)pivotal(dot)io, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14706: Dependencies not recorded properly for base types |
| Date: | 2017-06-15 16:31:40 |
| Message-ID: | 11135.1497544300@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> Hmm. Strictly speaking there's no need to update the dependency when
> changing opaque into cstring. Because cstring is a pinned type,
> recordDependency will do nothing for it.
> But in any case, I think it'd be better and simpler to fix the
> dependency in SetFunctionArgType() and SetFunctionReturnType() functions
> themselves. They're the ones that change the type, they ought to be
> responsible for fixing the dependency too. See attached.
Yeah, Heikki's version looks good to me.
Heikki, are you going to commit/backpatch this, or do you want me to?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-06-15 16:38:24 | Re: BUG #14706: Dependencies not recorded properly for base types |
| Previous Message | 厚积薄发 | 2017-06-15 16:08:41 | GIN index vacuum hang after pg_rman restore in PG9.2.21 |