From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, khuddleston(at)pivotal(dot)io, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: BUG #14706: Dependencies not recorded properly for base types |
Date: | 2017-06-16 01:54:25 |
Message-ID: | CAB7nPqTuRMiJBQC65hg4MZVZeUPo1S9qPQ3sVYLw3+bbpEKQ_Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Fri, Jun 16, 2017 at 1:38 AM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> On 06/15/2017 07:31 PM, Tom Lane wrote:
>>
>> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>>>
>>> Hmm. Strictly speaking there's no need to update the dependency when
>>> changing opaque into cstring. Because cstring is a pinned type,
>>> recordDependency will do nothing for it.
>>
>>> But in any case, I think it'd be better and simpler to fix the
>>> dependency in SetFunctionArgType() and SetFunctionReturnType() functions
>>> themselves. They're the ones that change the type, they ought to be
>>> responsible for fixing the dependency too. See attached.
>>
>> Yeah, Heikki's version looks good to me.
>>
>> Heikki, are you going to commit/backpatch this, or do you want me to?
>
> I can do it, thanks.
Fine for me. My first quick guess was better than what I coded at the
end, the idea being to wait after TypeCreate() to get the ObjectAdress
of the new type.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | 厚积薄发 | 2017-06-16 02:41:23 | Re: GIN index vacuum hang after pg_rman restore in PG9.2.21 |
Previous Message | Michael Paquier | 2017-06-16 01:32:22 | Re: BUG #14708: Frequent connection timeout issue while connecting to Postgres database |