| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | chenjq(dot)jy(at)fujitsu(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17149: About --skip option of pg_amcheck command |
| Date: | 2021-08-17 07:54:12 |
| Message-ID: | 1CCC492A-161A-4349-827D-7AB584D3FEFC@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> On 17 Aug 2021, at 06:36, PG Bug reporting form <noreply(at)postgresql(dot)org> wrote:
> When I specify the "none" value for --skip option, the following error
> occurs:
> [postgres14(at)localhost ~]$ pg_amcheck -p 51403 -d postgres -t tb01
> --skip=none
> pg_amcheck: error: invalid argument for option --skip
> [postgres14(at)localhost ~]$
Nice catch, this should indeed be handled. Fixed in the attached.
> When I specify the "all-visible" or "all-frozen" value for --skip
> option, take "all-visible" as an example, the following error occurs:
> [postgres14(at)localhost ~]$ pg_amcheck -p 51403 -d postgres -t tb01
> --skip=all-visible
> 2021-08-16 04:59:04.571 EDT [4689] ERROR: invalid skip option
> 2021-08-16 04:59:04.571 EDT [4689] HINT: Valid skip options are
> "all-visible", "all-frozen", and "none".
Indeed, the attached fixes this as well.
Barring objections I will apply the attached backpatched to 14.
--
Daniel Gustafsson https://vmware.com/
| Attachment | Content-Type | Size |
|---|---|---|
| pg_amcheck_skip.diff | application/octet-stream | 660 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-08-17 08:14:18 | Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command |
| Previous Message | PG Bug reporting form | 2021-08-17 04:36:44 | BUG #17149: About --skip option of pg_amcheck command |