Re: BUG #17149: About --skip option of pg_amcheck command

On Tue, Aug 17, 2021 at 4:54 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 17 Aug 2021, at 06:36, PG Bug reporting form <noreply(at)postgresql(dot)org> wrote:
>
> > When I specify the "none" value for --skip option, the following error
> > occurs:
> > [postgres14(at)localhost ~]$ pg_amcheck -p 51403 -d postgres -t tb01
> > --skip=none
> > pg_amcheck: error: invalid argument for option --skip
> > [postgres14(at)localhost ~]$
>
> Nice catch, this should indeed be handled. Fixed in the attached.
>
> > When I specify the "all-visible" or "all-frozen" value for --skip
> > option, take "all-visible" as an example, the following error occurs:
> > [postgres14(at)localhost ~]$ pg_amcheck -p 51403 -d postgres -t tb01
> > --skip=all-visible
> > 2021-08-16 04:59:04.571 EDT [4689] ERROR: invalid skip option
> > 2021-08-16 04:59:04.571 EDT [4689] HINT: Valid skip options are
> > "all-visible", "all-frozen", and "none".
>
> Indeed, the attached fixes this as well.
>
> Barring objections I will apply the attached backpatched to 14.

The patch looks good to me.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/