Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: chenjq(dot)jy(at)fujitsu(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command
Date: 2021-08-17 08:14:18
Message-ID: B9A9C944-9EAC-421C-8044-EF109ADAC4D4@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 17 Aug 2021, at 06:34, PG Bug reporting form <noreply(at)postgresql(dot)org> wrote:

> In PG14 beta3, when I use pg_amcheck command, both --no-strict-names
> option and --quiet option are specified, the warning message of --database
> option is not suppressed.
> The official website is described as follows:
>> --no-strict-names
>> By default, if an argument to --database, --table, --index, or
> --relation matches no objects, it is a fatal error.
>> This option downgrades that error to a warning. If this option is
> used with --quiet, the warning will be suppressed as well.
>
> When I specify a non-existent database name for the --database option,
> and specify the --no-strict-names option and the --quiet option,
> pg_amcheck command should not return any message, but it still returns
> the warning message.

Agreed, in order to match the documentation the attached is required, which
also matches other invocations of log_no_match(). This should be applied
backpatched to 14 unless there are objections.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
pg_amcheck_strict_names.diff application/octet-stream 603 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Heikki Linnakangas 2021-08-17 08:28:31 Re: BUG #17142: COPY ignores client_encoding for octal digit characters
Previous Message Daniel Gustafsson 2021-08-17 07:54:12 Re: BUG #17149: About --skip option of pg_amcheck command