Re: [HACKERS] Re: [SQL] Column name's length

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Zalman Stern <zalman(at)netcom(dot)com>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Re: [SQL] Column name's length
Date: 1999-06-01 14:45:13
Message-ID: 199906011445.KAA26265@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Zalman Stern <zalman(at)netcom(dot)com> writes:
> > Here are the two diffs that up the "name size" from 32 characters to 256
> > characters. (Once I get bit, I try to fix things real good so I don't get
> > bit again :-))
> > -----
> > diff postgresql-6.4.2/src/include/postgres_ext.h postgres-build/src/include/postgres_ext.h
> > 34c34
> > < #define NAMEDATALEN 32
> > ---
> >> #define NAMEDATALEN 256
> > 37c37
> > < #define OIDNAMELEN 36
> > ---
> >> #define OIDNAMELEN 260
> > -----
> > diff postgresql-6.4.2/src/include/storage/buf_internals.h postgres-build/src/include/storage/buf_internals.h
> > 87c87
> > < #define PADDED_SBUFDESC_SIZE 128
> > ---
> >> #define PADDED_SBUFDESC_SIZE 1024
> > -----
>
> It'd probably be worthwhile to move NAMEDATALEN to config.h and make the
> other two symbols be computed off NAMEDATALEN. Any objections if I
> sneak that change into 6.5, or is it too close to being a "new feature"?

Don't they have to be visible to outside apps, so it is in postgres_ext.h?

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1999-06-01 14:46:32 Re: [HACKERS] Release date and docs
Previous Message Chris Bitmead 1999-06-01 14:42:50 Re: [HACKERS] LIMITS