Re: [HACKERS] Re: [SQL] Column name's length

From: Peter T Mount <peter(at)retep(dot)org(dot)uk>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zalman Stern <zalman(at)netcom(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Re: [SQL] Column name's length
Date: 1999-06-01 20:06:06
Message-ID: Pine.LNX.4.04.9906012104550.2434-100000@maidast.retep.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 1 Jun 1999, Bruce Momjian wrote:

> > Zalman Stern <zalman(at)netcom(dot)com> writes:
> > > Here are the two diffs that up the "name size" from 32 characters to 256
> > > characters. (Once I get bit, I try to fix things real good so I don't get
> > > bit again :-))
> > > -----
> > > diff postgresql-6.4.2/src/include/postgres_ext.h postgres-build/src/include/postgres_ext.h
> > > 34c34
> > > < #define NAMEDATALEN 32
> > > ---
> > >> #define NAMEDATALEN 256
> > > 37c37
> > > < #define OIDNAMELEN 36
> > > ---
> > >> #define OIDNAMELEN 260
> > > -----
> > > diff postgresql-6.4.2/src/include/storage/buf_internals.h postgres-build/src/include/storage/buf_internals.h
> > > 87c87
> > > < #define PADDED_SBUFDESC_SIZE 128
> > > ---
> > >> #define PADDED_SBUFDESC_SIZE 1024
> > > -----
> >
> > It'd probably be worthwhile to move NAMEDATALEN to config.h and make the
> > other two symbols be computed off NAMEDATALEN. Any objections if I
> > sneak that change into 6.5, or is it too close to being a "new feature"?
>
> Don't they have to be visible to outside apps, so it is in postgres_ext.h?

We would need to have some way of getting at it from the client - the
DatabaseMetaData method getColumnNameLength() would need to know about
this, and we can't refer to the C header files.

Peter

--
Peter T Mount peter(at)retep(dot)org(dot)uk
Main Homepage: http://www.retep.org.uk
PostgreSQL JDBC Faq: http://www.retep.org.uk/postgres
Java PDF Generator: http://www.retep.org.uk/pdf

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Keala Jacobs 1999-06-01 20:14:05 variables in psql
Previous Message Bruce Momjian 1999-06-01 17:37:00 Re: [HACKERS] LIMITS