Re: [HACKERS] Adding some const keywords to external interfaces

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: darcy(at)druid(dot)net (D'ArcyJ(dot)M(dot)Cain)
Cc: darcy(at)druid(dot)net, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Adding some const keywords to external interfaces
Date: 1999-02-02 18:36:11
Message-ID: 199902021836.NAA28569@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

We agreed to skip this right now, right?

> Thus spake Bruce Momjian
> > These are good points. Can you post the patch again? I deleted it.
>
> I bounced it directly to you rather than reposting to the list.
>
> > Sounds like it would be safe. I am interested in const-ify-ing the
> > backend code, if possible. It does offer a level of code checking that
> > we don't currently have.
>
> Me too but as I said, this patch doesn't do that. It only const-ifies
> the the arguments to an external interface.
>
> > The only issue is that is has to be done pretty exhaustively. If you
> > don't, your new const function parameters start passing params to
> > functions that takes non-const params, and warnings start to fly.
>
> I compiled the entire tree without any warnings so I assume that the
> changes wound up being pretty localized.
>
> --
> D'Arcy J.M. Cain <darcy(at){druid|vex}.net> | Democracy is three wolves
> http://www.druid.net/darcy/ | and a sheep voting on
> +1 416 424 2871 (DoD#0082) (eNTP) | what's for dinner.
>
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1999-02-02 18:40:08 Re: [HACKERS] help bug and comment char.
Previous Message Bruce Momjian 1999-02-02 17:05:03 Re: [HACKERS] Postgres Speed or lack thereof