From: | "D'Arcy" "J(dot)M(dot)" Cain <darcy(at)druid(dot)net> |
---|---|
To: | maillist(at)candle(dot)pha(dot)pa(dot)us (Bruce Momjian) |
Cc: | darcy(at)druid(dot)net, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] Adding some const keywords to external interfaces |
Date: | 1999-02-02 18:58:28 |
Message-ID: | m107l1o-0000bNC@druid.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thus spake Bruce Momjian
> We agreed to skip this right now, right?
I still think it's benign at worst. Shall I keepthe changes and resubmit
later?
> > Thus spake Bruce Momjian
> > > These are good points. Can you post the patch again? I deleted it.
> >
> > I bounced it directly to you rather than reposting to the list.
> >
> > > Sounds like it would be safe. I am interested in const-ify-ing the
> > > backend code, if possible. It does offer a level of code checking that
> > > we don't currently have.
> >
> > Me too but as I said, this patch doesn't do that. It only const-ifies
> > the the arguments to an external interface.
> >
> > > The only issue is that is has to be done pretty exhaustively. If you
> > > don't, your new const function parameters start passing params to
> > > functions that takes non-const params, and warnings start to fly.
> >
> > I compiled the entire tree without any warnings so I assume that the
> > changes wound up being pretty localized.
--
D'Arcy J.M. Cain <darcy(at){druid|vex}.net> | Democracy is three wolves
http://www.druid.net/darcy/ | and a sheep voting on
+1 416 424 2871 (DoD#0082) (eNTP) | what's for dinner.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 1999-02-02 19:06:55 | Re: [HACKERS] Something wacko about EXPLAIN cost stats |
Previous Message | Bruce Momjian | 1999-02-02 18:51:34 | Re: [PATCHES] MB big5 support patch (current) |