| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com>, Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] Custom variable class segmentation fault |
| Date: | 2006-08-15 19:22:19 |
| Message-ID: | 19268.1155669739@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> I merely said that the way the patch was presented, with significant
> code refactoring mixed in, I couldn't review it (as effectively as
> perhaps otherwise). FWIW, I believe that the general approach is
> sound, but I haven't actually "reviewed" the patch completely.
Given the multiple problems already found, I feel quite uncomfortable
with putting it back in until another set of eyeballs has been over
it. Do you have time to do a full review anytime soon? I'm trying
to deal with all the other stuff in the queue, and so would prefer
not to spend my own time on it ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-08-15 19:29:05 | Re: [HACKERS] Forcing current WAL file to be archived |
| Previous Message | Tom Lane | 2006-08-15 19:08:09 | Re: [PATCHES] PL instrumentation plugin and Rendezvous variable support - version 2 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-08-15 19:29:05 | Re: [HACKERS] Forcing current WAL file to be archived |
| Previous Message | Tom Lane | 2006-08-15 19:08:09 | Re: [PATCHES] PL instrumentation plugin and Rendezvous variable support - version 2 |