| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] Custom variable class segmentation fault |
| Date: | 2006-08-15 16:30:32 |
| Message-ID: | 200608151830.33645.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Andrew Dunstan wrote:
> If you and Peter have reviewed it thoroughly then I see no reason the
> patch should not be applied.
I merely said that the way the patch was presented, with significant
code refactoring mixed in, I couldn't review it (as effectively as
perhaps otherwise). FWIW, I believe that the general approach is
sound, but I haven't actually "reviewed" the patch completely.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | AgentM | 2006-08-15 16:33:07 | Re: An Idea for planner hints |
| Previous Message | Jaime Casanova | 2006-08-15 16:27:10 | insert/update/delete returning and rules |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2006-08-15 17:07:12 | Re: Forcing current WAL file to be archived |
| Previous Message | Tom Lane | 2006-08-15 16:22:05 | Re: [Patch] - Fix for bug #2558, InitDB failed to run |