| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Check that we have a working tar before trying to use it |
| Date: | 2021-12-13 16:47:36 |
| Message-ID: | 190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 12/13/21 03:08, Michael Paquier wrote:
> Also,
> the default values of LZ4, TAR and GZIP_PROGRAM had better be set
> *before* loading buildenv.pl, and not after it is loaded, no? On
> HEAD, one has no way to unset any of those variables so it is not
> possible to skip things if an environment has in its PATH a funky
> command that TAP would refuse, like a tar command from MinGW or the
> git installation.
No. The code only sets them if they have not been previously set by
buildenv.pl or the calling environment. That's what "||=" means.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-12-13 16:57:36 | pgsql: Suppress -Warray-bounds warning in 9.2's xlog.c. |
| Previous Message | Tom Lane | 2021-12-13 16:22:13 | pgsql: Suppress -Wformat-overflow warnings in 9.2's xml.c. |