From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Suppress -Wformat-overflow warnings in 9.2's xml.c. |
Date: | 2021-12-13 16:22:13 |
Message-ID: | E1mwo5d-0004fQ-Pf@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Suppress -Wformat-overflow warnings in 9.2's xml.c.
If not using --with-libxml, late-model gcc complains about "'%s'
directive argument is null" in places where xml.c passes the result
of map_sql_identifier_to_xml_name() to %s. That's not so surprising,
because without USE_LIBXML the body of that function is
NO_XML_SUPPORT();
return NULL;
and before 9.3 the compiler won't understand that NO_XML_SUPPORT()
doesn't return. Silence the warnings by returning "" instead.
We don't need this hack in later branches, AFAICT.
Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com
Branch
------
REL9_2_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3f9700acb238fced605ff3ef155e179290fd4f02
Modified Files
--------------
src/backend/utils/adt/xml.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2021-12-13 16:47:36 | Re: pgsql: Check that we have a working tar before trying to use it |
Previous Message | Robert Haas | 2021-12-13 15:10:26 | pgsql: Remove InitXLOGAccess(). |