Fix attributes of consume_xids and consume_xids_until

From: Yushi Ogiwara <btogiwarayuushi(at)oss(dot)nttdata(dot)com>
To: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Fix attributes of consume_xids and consume_xids_until
Date: 2024-10-11 06:59:05
Message-ID: 18f01e4fd46448f88c7a1363050a9955@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I found the attributes of the functions consume_xids and
consume_xids_until are incorrectly specified:

- Both functions are marked as IMMUTABLE attribute, but they advance the
transaction ID, which modifies the system state. Thus, they should be
marked as VOLATILE.
- Additionally, both functions are marked as PARALLEL SAFE. Since these
functions call the AssignTransactionId function, which cannot be invoked
in parallel mode, they should be marked as PARALLEL UNSAFE.

This patch fixes the attributes of consume_xids and consume_xids_until
accordingly.

Best,
Yushi

Attachment Content-Type Size
fix_attr.diff text/x-diff 1.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2024-10-11 07:18:04 Re: Remove unlogged materialized view persistence handling
Previous Message Laurenz Albe 2024-10-11 06:50:49 Re: sunsetting md5 password support