Re: Fix attributes of consume_xids and consume_xids_until

On 11/10/2024 09:59, Yushi Ogiwara wrote:
> Hi,
>
> I found the attributes of the functions consume_xids and
> consume_xids_until are incorrectly specified:
>
> - Both functions are marked as IMMUTABLE attribute, but they advance the
> transaction ID, which modifies the system state. Thus, they should be
> marked as VOLATILE.
> - Additionally, both functions are marked as PARALLEL SAFE. Since these
> functions call the AssignTransactionId function, which cannot be invoked
> in parallel mode, they should be marked as PARALLEL UNSAFE.
>
> This patch fixes the attributes of consume_xids and consume_xids_until
> accordingly.

Applied, thanks!

I didn't backpatch this because it's a test module that shouldn't be
installed in production. And because we don't bother with upgrade
scripts for these test modules, it could get confusing.

--
Heikki Linnakangas
Neon (https://neon.tech)