Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
Date: 2021-02-13 22:59:09
Message-ID: 1870527.1613257149@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
>> On Fri, Feb 12, 2021 at 8:19 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Once this does settle, should we consider back-patching so that it's
>>> possible to run alignment checks in the back branches too?

>> +1

> Let's make sure we have a clean set of builds and then do that.

The buildfarm seems to be happy --- the active members that haven't
reported in should be unaffected by this patch, either because their
compiler versions are too old or because they're not x86 architecture.
So I went ahead and back-patched, and have adjusted longfin to apply
the -fsanitize switch in all branches.

(I've checked that 9.6 passes check-world this way, but not the
intermediate branches, so it's possible something will fail...)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2021-02-14 00:42:28 Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
Previous Message Tom Lane 2021-02-13 22:49:58 pgsql: pg_attribute_no_sanitize_alignment() macro

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-02-13 23:32:03 Re: pg_cryptohash_final possible out-of-bounds access (per Coverity)
Previous Message Stephen Frost 2021-02-13 21:39:30 Re: WIP: WAL prefetch (another approach)