pgsql: pg_attribute_no_sanitize_alignment() macro

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_attribute_no_sanitize_alignment() macro
Date: 2021-02-13 22:49:58
Message-ID: E1lB3ji-0005TL-D9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_attribute_no_sanitize_alignment() macro

Modern gcc and clang compilers offer alignment sanitizers, which help to detect
pointer misalignment. However, our codebase already contains x86-specific
crc32 computation code, which uses unalignment access. Thankfully, those
compilers also support the attribute, which disables alignment sanitizers at
the function level. This commit adds pg_attribute_no_sanitize_alignment(),
which wraps this attribute, and applies it to pg_comp_crc32c_sse42() function.

Back-patch of commits 993bdb9f9 and ad2ad698a, to enable doing
alignment testing in all supported branches.

Discussion: https://postgr.es/m/CAPpHfdsne3%3DT%3DfMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w%40mail.gmail.com
Discussion: https://postgr.es/m/475514.1612745257%40sss.pgh.pa.us
Author: Alexander Korotkov, revised by Tom Lane
Reviewed-by: Tom Lane

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/02e7da01a4362ca241e814d5bf9793e849f1c90c

Modified Files
--------------
src/include/c.h | 12 ++++++++++++
src/port/pg_crc32c_sse42.c | 1 +
2 files changed, 13 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-02-13 22:59:09 Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
Previous Message Bruce Momjian 2021-02-13 18:51:02 pgsql: README/C-comment: document GiST's NSN value