Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
Date: 2021-02-12 22:55:00
Message-ID: 1611008.1613170500@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> On Fri, Feb 12, 2021 at 8:19 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> So maybe it'd better be __GNUC__ >= 6 not __GNUC__ >= 5. I think
>> we can wait a little bit for more reports before messing with that,
>> though.

> I've rechecked this in the documentation. no_sanitize attribute seems
> to appear since gcc 8.0. Much later than alignment sanitizer itself.

Yeah, I'd just come to that conclusion from scraping the buildfarm
logs. Good to see it confirmed in the manual though.

>> Once this does settle, should we consider back-patching so that it's
>> possible to run alignment checks in the back branches too?

> +1

Let's make sure we have a clean set of builds and then do that.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2021-02-13 01:17:35 Re: pgsql: Allow multiple xacts during table sync in logical replication.
Previous Message Tom Lane 2021-02-12 22:50:07 Re: pgsql: Allow multiple xacts during table sync in logical replication.

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-02-13 00:37:32 Re: Improvements and additions to COPY progress reporting
Previous Message Tom Lane 2021-02-12 22:35:46 Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)