Re: [HACKERS] psql and libpq fixes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] psql and libpq fixes
Date: 2000-02-08 15:50:14
Message-ID: 1777.950025014@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <e99re41(at)DoCS(dot)UU(dot)SE> writes:
>> In general, an existing script is not going to be written with the idea
>> that psql will cut it off at the knees for provoking an error. If the
>> author *does* want all the rest of the commands to be skipped on error,
>> he'll just have written BEGIN and END around the whole script.

> Last time I checked you couldn't roll back a create table. ;)

Au contraire, rolling back a CREATE works fine. It's rolling back
a DROP that gives trouble ;-)

This does bring up a thought --- should psql's kill-the-script-on-error
option perhaps zap the script only for errors committed outside of a
transaction block? I'm not sure how hard it is for psql to keep track
of whether the script is in an xact, so maybe this'd be far harder than
it's worth. Seems like it deserves some consideration though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-02-08 15:52:28 Re: [HACKERS] New Globe
Previous Message Karel Zak - Zakkr 2000-02-08 15:44:37 Re: [HACKERS] CFH: Mariposa, distributed DB