From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [HACKERS] psql and libpq fixes |
Date: | 2000-02-08 16:02:01 |
Message-ID: | 200002081602.LAA27899@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Peter Eisentraut <e99re41(at)DoCS(dot)UU(dot)SE> writes:
> >> In general, an existing script is not going to be written with the idea
> >> that psql will cut it off at the knees for provoking an error. If the
> >> author *does* want all the rest of the commands to be skipped on error,
> >> he'll just have written BEGIN and END around the whole script.
>
> > Last time I checked you couldn't roll back a create table. ;)
>
> Au contraire, rolling back a CREATE works fine. It's rolling back
> a DROP that gives trouble ;-)
>
> This does bring up a thought --- should psql's kill-the-script-on-error
> option perhaps zap the script only for errors committed outside of a
> transaction block? I'm not sure how hard it is for psql to keep track
> of whether the script is in an xact, so maybe this'd be far harder than
> it's worth. Seems like it deserves some consideration though.
Why is being in a transaction block important?
--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2000-02-08 16:14:46 | Ordering of pg_dump output |
Previous Message | Tom Lane | 2000-02-08 16:00:34 | Re: [HACKERS] docs and createlang patch for plperl |