| From: | keisuke kuroda <keisuke(dot)kuroda(dot)3862(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Aleksander Alekseev <afiskon(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Improve code coverage of network address functions |
| Date: | 2025-01-28 07:24:38 |
| Message-ID: | 173804907807.528.6892612759588298489.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: tested, failed
Thank you for your patch!
I have confirmed that the coverage improves
to the expected value（69.7%->83.0%)
source: commit 75eb9766ec201b62f264554019757716093e2a2f(HEAD)
## add with-openssl option for ssltest
./configure --enable-coverage --enable-tap-tests --with-llvm --with-openssl CFLAGS=-O0
make check-world PG_TEST_EXTRA='ssl' -j 4 > /tmp/regress.log
make coverage-html
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-01-28 07:38:02 | Re: [PATCH] Improve code coverage of network address functions |
| Previous Message | Ashutosh Bapat | 2025-01-28 06:31:35 | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |