From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | keisuke kuroda <keisuke(dot)kuroda(dot)3862(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Aleksander Alekseev <afiskon(at)gmail(dot)com> |
Subject: | Re: [PATCH] Improve code coverage of network address functions |
Date: | 2025-01-28 07:38:02 |
Message-ID: | Z5iJWu6jkpm2GYou@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 28, 2025 at 07:24:38AM +0000, keisuke kuroda wrote:
> I have confirmed that the coverage improves
> to the expected value(69.7%->83.0%)
>
> source: commit 75eb9766ec201b62f264554019757716093e2a2f(HEAD)
> ## add with-openssl option for ssltest
> ./configure --enable-coverage --enable-tap-tests --with-llvm --with-openssl CFLAGS=-O0
> make check-world PG_TEST_EXTRA='ssl' -j 4 > /tmp/regress.log
> make coverage-html
Aleksander has mentioned me this patch a couple of days ago. Forgot a
bit about it.
The SQL additions seem sensible to me at quick glance (will
double-check the coverage numbers a bit later). Thanks for compiling
that.
About the tests pushed to the SSL test suite, I'm +-0. 003_sslinfo.pl
is a bit better than the two others in the SSL test suite, still it
does not really fit into this file.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Keisuke Kuroda | 2025-01-28 07:48:09 | Re: [PATCH] Improve code coverage of network address functions |
Previous Message | keisuke kuroda | 2025-01-28 07:24:38 | Re: [PATCH] Improve code coverage of network address functions |