Re: [PATCH] Improve code coverage of network address functions

Hi everyone,

Many thanks for all your great feedback.

> In any case, Aleksander, I don't mean to sign you up for all that; the
> `ssl` suite also seems good enough to me if you're interested in
> pursuing that side of the patch further.

OK, I moved the named tests to src/test/ssl/t/003_sslinfo.pl:

```
$ PG_TEST_EXTRA=ssl meson test -C build --suite postgresql:ssl
$ less build/meson-logs/testlog.txt
[...]
ok 22 - inet_client_addr() returned non-NULL value
ok 23 - inet_client_port() returned non-NULL value
ok 24 - inet_server_addr() returned non-NULL value
ok 25 - inet_server_port() returned non-NULL value
[...]
```

> Adding the following cases to the set_masklen()
> test would further improve coverage.
> * netmask = -1
> * netmask > maxvalue(33 when ipv4)

Good idea. I included the proposed tests into the attached patch v2.

While on it I noticed the following comment:

```
-- check the conversion to/from text and set_netmask
```

Since we don't have set_netmask() I think the comment is wrong, so I
corrected it.

--
Best regards,
Aleksander Alekseev