From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based |
Date: | 2020-09-07 17:13:00 |
Message-ID: | 1697751.1599498780@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2020-Sep-07, Tom Lane wrote:
>> I didn't bother tracking down exactly where initdb.c is getting
>> stringinfo.h from, but it clearly does import it somewhere in
>> our rat's nest of headers.
> You can see it here: https://doxygen.postgresql.org/initdb_8c.html
> It's through xlog_internal.h (not that it matters much).
If there were something to be on the warpath about, it's that initdb
is pulling in such an obviously backend-only header as that. I wonder
if we should refactor to fix that.
Quick experimentation says that the symbols initdb actually needs out
of that header are
DEFAULT_MIN_WAL_SEGS
DEFAULT_MAX_WAL_SEGS
IsValidWalSegSize()
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2020-09-07 17:34:38 | Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based |
Previous Message | Pavel Stehule | 2020-09-07 17:00:54 | Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based |