| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based |
| Date: | 2020-09-07 17:00:54 |
| Message-ID: | CAFj8pRDMLw4fiik9p0-VUDSB29F9cv8hiyPpsWwDSo-2mz5v8Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
po 7. 9. 2020 v 18:58 odesílatel Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
napsal:
> On 2020-Sep-07, Tom Lane wrote:
>
> > Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > > here is a patch
> >
> > What exactly is this supposed to fix?
> >
> > I didn't bother tracking down exactly where initdb.c is getting
> > stringinfo.h from, but it clearly does import it somewhere in
> > our rat's nest of headers.
>
> You can see it here: https://doxygen.postgresql.org/initdb_8c.html
> It's through xlog_internal.h (not that it matters much).
>
> We do the indirect-header thing all over the place. There's no point in
> trying to avoid it completely.
>
ok
Pavel
> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-09-07 17:13:00 | Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based |
| Previous Message | Alvaro Herrera | 2020-09-07 16:58:44 | Re: pgsql: Refactor pg_get_line() to expose an alternative StringInfo-based |