| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Scott Milliken <scott(at)deltaex(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14758: Segfault with logical replication on a function index |
| Date: | 2017-08-02 15:36:54 |
| Message-ID: | 14897772-f4d9-296e-d20f-12fcbf5e1331@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 8/1/17 21:23, Masahiko Sawada wrote:
> On Wed, Aug 2, 2017 at 7:52 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> On 2017-08-01 16:28:31 -0400, Peter Eisentraut wrote:
>>> On 7/28/17 06:07, Masahiko Sawada wrote:
>>>> I could reproduced this issue and it seems to me that the cause of
>>>> this is that the table sync worker didn't get a snapshot before
>>>> starting table copy. Attached patch fixes this problem.
>>>
>>> Should it be GetTransactionSnapshot() rather than GetLatestSnapshot()?
>>
>> Don't think it makes a meaningful difference here, but I agree it's more
>> consistent.
>
> +1.
committed with that change
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-08-02 16:04:35 | Re: BUG #14764: #if HASH_DEBUG source in dynahash.c is fault. |
| Previous Message | Jov | 2017-08-02 14:24:12 | Re: BUG #14765: Recreating databases from copied files. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-08-02 15:50:01 | Re: pgbench: Skipping the creating primary keys after initialization |
| Previous Message | Robert Haas | 2017-08-02 15:34:13 | Re: pgsql 10: hash indexes testing |