Re: BUG #14758: Segfault with logical replication on a function index

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Scott Milliken <scott(at)deltaex(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14758: Segfault with logical replication on a function index
Date: 2017-08-03 00:59:50
Message-ID: CAD21AoDGonbnNZtHmG77VTRVbdLqtFCciHci1ULMAaiSsAhQ9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Aug 3, 2017 at 12:36 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 8/1/17 21:23, Masahiko Sawada wrote:
>> On Wed, Aug 2, 2017 at 7:52 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>>> On 2017-08-01 16:28:31 -0400, Peter Eisentraut wrote:
>>>> On 7/28/17 06:07, Masahiko Sawada wrote:
>>>>> I could reproduced this issue and it seems to me that the cause of
>>>>> this is that the table sync worker didn't get a snapshot before
>>>>> starting table copy. Attached patch fixes this problem.
>>>>
>>>> Should it be GetTransactionSnapshot() rather than GetLatestSnapshot()?
>>>
>>> Don't think it makes a meaningful difference here, but I agree it's more
>>> consistent.
>>
>> +1.
>
> committed with that change
>

Thank you!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Ashesh Vashi 2017-08-03 01:19:58 Re: pgAdmin 4 issues
Previous Message scott 2017-08-02 23:59:27 BUG #14769: Logical replication error "cache lookup failed for type 0"

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-08-03 01:31:56 Re: Partition-wise join for join between (declaratively) partitioned tables
Previous Message Tatsuo Ishii 2017-08-03 00:53:46 Re: Confusing error message in pgbench