Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu
Date: 2017-09-25 19:09:09
Message-ID: 14181.1506366549@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 9/21/17 18:13, Tom Lane wrote:
>> Give a better error for duplicate entries in VACUUM/ANALYZE column list.

> In the error message, we should write "specified more than once" instead
> of "specified twice", because that could otherwise look a bit silly:
> VACUUM ANALYZE vaccluster(i,i,i);
> ERROR: column "i" of relation "vaccluster" is specified twice

OK.

> (Also, the "is" doesn't seem to fit there.)

Hm, reads fine to me, and I'd still rather include "is" in the
revised wording. Anybody else agree with Peter's wording?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-25 20:09:36 pgsql: Avoid SIGBUS on Linux when a DSM memory request overruns tmpfs.
Previous Message Peter Eisentraut 2017-09-25 18:51:44 Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu