Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu
Date: 2017-09-25 18:51:44
Message-ID: 862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 9/21/17 18:13, Tom Lane wrote:
> Give a better error for duplicate entries in VACUUM/ANALYZE column list.
>
> Previously, the code didn't think about this case and would just try to
> analyze such a column twice.

In the error message, we should write "specified more than once" instead
of "specified twice", because that could otherwise look a bit silly:

VACUUM ANALYZE vaccluster(i,i,i);
ERROR: column "i" of relation "vaccluster" is specified twice

(Also, the "is" doesn't seem to fit there.)

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-25 19:09:09 Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu
Previous Message Tom Lane 2017-09-25 15:55:30 pgsql: Make construct_[md_]array return a valid empty array for zero-si