Re: Summary function for pg_buffercache

From: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
To: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Summary function for pg_buffercache
Date: 2022-09-28 15:07:49
Message-ID: 13e3e68a-8266-402e-93c2-5e126c40cc74@Spark
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Sep 28, 2022, 22:41 +0800, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, wrote:
>
>
> Zhang Mingli <zmlpostgres(at)gmail(dot)com>, 28 Eyl 2022 Çar, 17:31 tarihinde şunu yazdı:
> > Why compute usagecount_avg twice?
>
> I should have removed the first one, but I think I missed it.
> Nice catch.
>
> Attached an updated version.
>
> Thanks,
> Melih
>
Hmm, I just apply v13 patch but failed.

Part of errors:
```
error: patch failed: contrib/pg_buffercache/pg_buffercache.control:1 error: contrib/pg_buffercache/pg_buffercache.control: patch does not apply
Checking patch contrib/pg_buffercache/pg_buffercache_pages.c...
error: while searching for:
 */
PG_FUNCTION_INFO_V1(pg_buffercache_pages);
PG_FUNCTION_INFO_V1(pg_buffercache_pages_v1_4);
```

Rebase on master and then apply our changes again?

Regards,
Zhang Mingli
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kaiting Chen 2022-09-28 15:14:00 Re: Allow foreign keys to reference a superset of unique columns
Previous Message Robert Haas 2022-09-28 15:02:37 Re: DROP OWNED BY is broken on master branch.