| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DROP OWNED BY is broken on master branch. |
| Date: | 2022-09-28 15:02:37 |
| Message-ID: | CA+TgmoYWymRaa5LReUZmi66jP0J9He6bhD6+KxLEv3do6dV5Pw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 28, 2022 at 8:21 AM Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> wrote:
> On Tue, Sep 27, 2022 at 7:34 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Sep 27, 2022 at 2:53 AM Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> wrote:
>> > Yes, I was also thinking to avoid the duplicate logic but couldn't found
>> > a way. I did the quick testing with the patch, and reported test is working
>> > fine. But "make check" is failing with few failures.
>>
>> Oh, woops. There was a dumb mistake in that version -- it was testing
>> sdepForm->dbid == SHARED_DEPENDENCY_OWNER, which is nonsense, instead
>> of sdepForm->dbid == MyDatabaseId. Here's a fixed version.
>
> This seems to fix the issue and in further testing I didn't find anything else.
OK, committed.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhang Mingli | 2022-09-28 15:07:49 | Re: Summary function for pg_buffercache |
| Previous Message | Bharath Rupireddy | 2022-09-28 14:46:08 | Move backup-related code to xlogbackup.c/.h |