Re: Fix comments in instr_time.h and remove an unneeded cast to int64

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix comments in instr_time.h and remove an unneeded cast to int64
Date: 2024-08-06 15:16:20
Message-ID: 1345020.1722957380@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> Hmm, ok I see. Then I propose:

> 1. Revert
> 2. Just fix the comment to say int64 instead of uint64.

Yeah, it's probably reasonable to specify the output as int64
not uint64 (especially since it looks like that's what the
macros actually produce).

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-08-06 15:52:16 Re: Minor refactorings to eliminate some static buffers
Previous Message Heikki Linnakangas 2024-08-06 15:13:56 Re: Minor refactorings to eliminate some static buffers