Re: Fix comments in instr_time.h and remove an unneeded cast to int64

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix comments in instr_time.h and remove an unneeded cast to int64
Date: 2024-08-06 19:18:45
Message-ID: 13243be4-5b76-4bed-8058-d72b2b82854b@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/08/2024 18:16, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Hmm, ok I see. Then I propose:
>
>> 1. Revert
>> 2. Just fix the comment to say int64 instead of uint64.
>
> Yeah, it's probably reasonable to specify the output as int64
> not uint64 (especially since it looks like that's what the
> macros actually produce).

Committed

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-08-06 19:20:14 Re: optimizing pg_upgrade's once-in-each-database steps
Previous Message Justin Pryzby 2024-08-06 19:10:15 Re: CI and test improvements