| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix comments in instr_time.h and remove an unneeded cast to int64 |
| Date: | 2024-08-06 14:49:32 |
| Message-ID: | 22385e4d-19b7-46e6-a969-52eb68624ca0@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/08/2024 17:20, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> On 06/08/2024 11:54, Bertrand Drouvot wrote:
>>> Please find attached a tiny patch to correct those and, in passing, remove what
>>> I think is an unneeded cast to int64.
>
>> Applied, thanks!
>
> I think this comment change is a dis-improvement. It's removed the
> documentation of the important fact that INSTR_TIME_GET_MICROSEC and
> INSTR_TIME_GET_NANOSEC return a different data type from
> INSTR_TIME_GET_MILLISEC (ie, integer versus float). Also, the
> expectation is that users of these APIs do not know the actual data
> type of instr_time, and instead we tell them what the output of those
> macros is. This patch just blew a hole in that abstraction.
Hmm, ok I see. Then I propose:
1. Revert
2. Just fix the comment to say int64 instead of uint64.
--
Heikki Linnakangas
Neon (https://neon.tech)
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Revert-Fix-comments-in-instr_time.h-and-remove-an-un.patch | text/x-patch | 1.6 KB |
| 0002-Fix-datatypes-in-comments-in-instr_time.h.patch | text/x-patch | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-08-06 14:50:00 | Re: SQL:2011 application time |
| Previous Message | Alvaro Herrera | 2024-08-06 14:45:48 | Re: Support multi-column renaming? |