| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | 大塚憲司 <otsuka(dot)kenji(at)nttcom(dot)co(dot)jp>, pgsql-docs(at)postgresql(dot)org, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] The number of bytes is stored in index_size of pgstatindex() ? |
| Date: | 2016-02-18 19:52:32 |
| Message-ID: | 13291.1455825152@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs pgsql-hackers |
I wrote:
> Peter Geoghegan <pg(at)heroku(dot)com> writes:
>> I think we should change it. It seems like a bug to me.
> Me too. Is it enough bug-like to be something to back-patch, or should
> we just change it in HEAD?
Actually, there's a significantly worse bug here: I just realized that the
page type tests are done in the wrong order. A deleted page that was
formerly a leaf will be reported as though it was a live leaf page,
because both the BTP_LEAF and BTP_DELETED flags are set for such a page.
It looks like this was done correctly to begin with, and I broke it in
d287818eb514d431b1a68e1f3940cd958f82aa34. Not sure what I was thinking :-(
Anyway, I think that puts the final nail in the coffin of the idea that
the current code's behavior is sane enough to preserve. I think we should
fix all these things and back-patch 'em all.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-02-18 22:56:58 | Re: [HACKERS] The number of bytes is stored in index_size of pgstatindex() ? |
| Previous Message | Peter Geoghegan | 2016-02-18 19:47:50 | Re: [HACKERS] The number of bytes is stored in index_size of pgstatindex() ? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2016-02-18 21:42:02 | Re: 9.5 new setting "cluster name" and logging |
| Previous Message | Peter Geoghegan | 2016-02-18 19:47:50 | Re: [HACKERS] The number of bytes is stored in index_size of pgstatindex() ? |