Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> No answer. Can we remove this chunk?
>> + if (no_role_passwords && binary_upgrade)
Perhaps, but why? ISTM that trying to run pg_upgrade as non-superuser
is a nonstarter for a number of reasons, while if you're superuser you
do not need --no-role-passwords.
regards, tom lane