| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Robins Tharakan <tharakan(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow pg_dumpall to work without pg_authid |
| Date: | 2017-03-24 03:28:47 |
| Message-ID: | 16d39c97-c295-ddce-f444-4eba611232e0@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/21/17 23:34, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> No answer. Can we remove this chunk?
>
>>> + if (no_role_passwords && binary_upgrade)
>
> Perhaps, but why? ISTM that trying to run pg_upgrade as non-superuser
> is a nonstarter for a number of reasons, while if you're superuser you
> do not need --no-role-passwords.
Well, this code was added, apparently without reason. We don't need to
actively prohibit option combinations just because they are unusual.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-24 03:46:36 | pg_dump --sequence-data option |
| Previous Message | Peter Eisentraut | 2017-03-24 03:27:11 | Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea) |