Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Raphael Hertzog <hertzog(at)debian(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Date: 2017-11-07 15:06:55
Message-ID: 11397.1510067215@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> My thought about this is just to ignore EINVAL when fsync'ing a directory,
>> as we already do with EBADF.

> Yeah, I suppose we could, just not sure that an EINVAL should really be
> getting returned here, imv.

Yeah, it does sound more like a filesystem bug than anything else.
(I completely reject the notion that it's an application error to
fsync a directory when you haven't modified it.)

In view of the fact that we just wrapped 10.1, it'd be 3 months before
any change from our side would reach the wild. I think a key question
here is whether the Kali developers are likely to fix it from their side
in less time than that.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2017-11-07 15:13:47 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Previous Message Raphael Hertzog 2017-11-07 15:06:02 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there