Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Raphael Hertzog <hertzog(at)debian(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Date: 2017-11-07 15:00:03
Message-ID: 20171107150002.GY4628@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > * Raphael Hertzog (hertzog(at)debian(dot)org) wrote:
> >> Still I believe that this issue should be fixed in both sides. It's not
> >> smart from PostgreSQL to call fsync() when it has not made any change.
>
> > Why?
>
> My thought about this is just to ignore EINVAL when fsync'ing a directory,
> as we already do with EBADF.

Yeah, I suppose we could, just not sure that an EINVAL should really be
getting returned here, imv.

Thanks!

Stephen

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2017-11-07 15:01:16 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Previous Message Tom Lane 2017-11-07 14:58:41 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there